Select option Box set all to selected

This site is best viewed in a modern browser with JavaScript enabled.

vagasv1

Hi I would like a button on my page that will automatically set all the options to selected

I have a select box

<select multiple="multiple" name="selVselect val">

<option value="2003SS">2003SS</option>
<option value="2003WA">2003WA</option>
<option value="2004SS">2004SS</option>
<option value="2004WA">2004WA</option>
<option value="2005SS">2005SS</option>
<option value="2005WA">2005WA</option>
<option value="2006SS">2006SS</option>


</select>

My function:

function selectall(f, control){
var controlName = "selV" + control;
oBoxList = document.forms[f].controlName;

for(var i=0; i<oBoxList.options.length;i++){
		oBoxList.options[i].selected=true;

}


}

My button:

<input type="button" value="select" onclick="selectall(this.form, select val">

the error I am getting is
Error: document.forms[f] has no properties

Please can anyone help?

Kor

Use JSON to write dynamically the objects properties

function selectall(f,control){
var opt = document.forms[f].elements['selV'+control].options;
var i=0, o;
while(o=opt[i++]){
o.selected=true;
}
}

make sure the the argument f is the name of the form. And, quite important, don't use empty spaces in names or ids. You may use underscore:

<select multiple="multiple" name="[B][COLOR="Red"]selVselect_val[/COLOR][/B]">

cridley

well, first you're passing in f which is the form object so instead of

oBoxList = document.forms[f].controlName;

you just want

oBoxList = f.controlName;

assuming both select box and button are in the same form.

Then you're missing a closing bracket in the onclick function here :

<input type="button" value="select" onclick="selectall(this.form, select val">

Then this :

onclick="selectall(this.form, select val)

variable name cannot contain spaces, which brings me to this :

name="selVselect val"

the name cannot have a space in it either.

UI-ZEIKVK

What is the name of your form. Is there more than one forms?

Kor

Well, yes, f seems to be the form object, thus my code will become:

function selectall(f,control){
var opt = f['selV'+control].options;
var i=0, o;
while(o=opt[i++]){
o.selected=true;
}
}
...
<select multiple="multiple" name="selV[COLOR="Red"]select_val[/COLOR]">
...
<input type="button" value="select" onclick="selectall(this.form,[COLOR="Red"]select_val[/COLOR]">

cridley

This works:

<html>
<body>

<script>
function selectall(f, control)
{
	var controlName = "selV" + control;
	oBoxList = f[controlName];

for(i=0; i<oBoxList.options.length;i++)
{
	oBoxList.options[i].selected=true;
}

}
</script>

<form>
<input type="button" value="select" onclick="selectall(this.form, 'select')" />
<select multiple="multiple" name="selVselect">

<option value="2003SS">2003SS</option>
<option value="2003WA">2003WA</option>
<option value="2004SS">2004SS</option>
<option value="2004WA">2004WA</option>
<option value="2005SS">2005SS</option>
<option value="2005WA">2005WA</option>
<option value="2006SS">2006SS</option>


</select>
</form>
</body>
</html>

vagasv1

Thanks you I have it working from a combination of your posts thanks

function selectall(f, control){
var controlName = "selV" + control;
var opt = f.elements[controlName].options;

var i=0, o;
while(o=opt[i++]){
o.selected=true;
}


}

It does work with spaces. I also need it to. I am writing an interface into my crystal reports server and the Select box name is created from from the parameter name so I need it to be able to work with spaces.

I suppose I could write a function that will iterate through the parameter name and replace spaces with _. but it seems to work fine with space all I have to do is

<input type="button" value="select" onclick="selectall(this.form, '<%=reportParameter.getParameterName()%>')">

thanks again

Kor

vagasv1 wrote:
It does work with spaces. I also need it to.

It does not matter what you need or want to, it matters only which is correctly written syntax. It is just incorrect to use spaces inside the id or name tokens (for reasons which overpass the beginner's needs to know). Some browsers might not like that and you might have problems:
See also:
http://www.w3.org/TR/html401/types.html#type-namehttp://www.w3.org/TR/html401/types.html#type-name

vagasv1

Yes Kor I do agree. If it was you would you write a funtction that will replace spaces with _s? I am not sure what is the best way to resolve this problem

Kor

You must let the ASP application to do that and write the names with underscore...

Kor

By the way, why do you need those spaces?