Cross Browser Event Listener

This site is best viewed in a modern browser with JavaScript enabled.

zidaine_38

Here is the cross browser code in adding multiple events in an element inside a document.

var addEvent = function ( el , ev , func ) {
	var evnt = el['on'+ev];
	el['on'+ev]= function () {
		if ( typeof evnt == "function" ) { evnt ();}
		func ();
	}
};


//example:
function ex () {
 alert(2);
}
addEvent (window , "load" , (function(){alert(1);}));
addEvent ( window, "load" , ex );

MrNobody

First problem I notice is that you lose the functionality of the passed event control block. Another problem is that you provide no means of communicating with the actual event via a returned true or false value.

chickeneater

I'm curious as to purpose of this code. Couldn't a conditional with addEventListener and attachEvent be used instead of a function for attaching events?

if(window.addEventListener){
window.addEventListener("load",function,false/true);
}else if(window.attachEvent){
window.attachEvent("onload",function);
}

Forgive me if I missed the question.

MrNobody

chickeneater;964923 wrote:
Forgive me if I missed the question.

Some people are forever trying to re-invent the wheel.

voidvector

MrNobody;964930 wrote:
Some people are forever trying to re-invent the wheel.

I wouldn't portray re-inventing the wheel as a bad thing. Just like every programmer has to write their own "hello world" program, every JavaScript developer should get acquainted with DOM before moving onto more abstract libraries.

MrNobody

voidvector;964987 wrote:
I wouldn't portray re-inventing the wheel as a bad thing.

I wouldn't -- as long as the re-invention is at least as good as the original. It must have some redeeming quality which makes it valuable over the original.