Better way to evaluate than eval()?

This site is best viewed in a modern browser with JavaScript enabled.

WolfShade

Hello, everyone.

I have a script that will loop through all the INPUT elements of a form; if the input is a submit it will disable the submit (or enable the submit, depending upon what is passed to the function.)

I hate using eval() - I avoid it whenever I can! Is there a better way to dynamically process the ".disabled = 'true'/'false';" portion?

// a function that will (dis/en)able all submit buttons
function edSubmit(thisStatus) { // thisStatus is either "true" or "false"
	var elementArray = new Array();
	elementArray = document.bft.getElementsByTagName("input");
	thisVar = ""; arrayLength = elementArray.length;
	for(i=0;i<arrayLength;i++) {
		if(/submit/i.test(elementArray[i].type)) {
			[color=blue]eval("document.bft."+elementArray[i].name+".disabled = " + thisStatus + ";");[/color]
			}
		}
	}

Thanks,

Declan1991

document.bft[elementArray].name.disabled

In fact, you can use that syntax all the time, for example, if you really wanted to:

window["document"]["bft"][elementArray[i]]["name"]["disabled"]

WolfShade

Thanks for the reply, Declan.

The way you have it typed, it didn't work:
document.bft[elementArray].name.disabled

But I tried it like:
document.bft[elementArray.name].disabled

.. and it will disable the submit buttons; but it will not re-enable the submit buttons when the "false" parameter is passed.

Likewise for:
window["document"]["bft"][elementArray]["name"]["disabled"]

I changed it to:
window["document"]["bft"][elementArray["name"]]["disabled"]

.. and it will disable but not re-enable the submit buttons.

1. document.bft[""+elementArray[i].name+""].disabled = thisStatus; 
2. window["document"]["bft"][elementArray[i]["name"]]["disabled"] = thisStatus;
3. document.bft[""+elementArray[i].name+""].disabled = ""+thisStatus; 
4. window["document"]["bft"][elementArray[i]["name"]]["disabled"] = ""+thisStatus;

Works for disabling the submits, but won't re-enable them, and is not throwing an error for console. Any ideas?

Fang

document.bft[elementArray[i].name].removeAttribute('disabled');

WolfShade

Error: uncaught exception: [Exception... "Cannot modify properties of a WrappedNative"  nsresult: "0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)"  location: "JS frame :: chrome://global/content/bindings/autocomplete.xml :: onxblpopuphiding :: line 825"  data: no]

Kor

Fang;1122006 wrote:
document.bft[elementArray[i].name].removeAttribute('disabled');

I guess better:

document.forms['bft'].elements[elementArray[i].name][COLOR="Blue"][i][/COLOR]

to avoid any mismatches.

WolfShade

Kor;1122011 wrote:
I guess better:
document.forms['bft'].elements[elementArray[i].name][COLOR="Blue"][i][/COLOR]
to avoid any mismatches.

Same error message.

WolfShade

I think I'm going to be stuck with using eval() for this. I've tried many different bracketed syntax formulas, and they all will disable the submit, but (for whatever reason) will not enable the submit upon either successful response or timeout due to lack of response.

As much as I hate eval(), it seems to be the only option (at least, for now.)

Thanks to everyone who offered suggestions/ideas. Much appreciated.