[RESOLVED] Undefined variable

This site is best viewed in a modern browser with JavaScript enabled.

kromol

Hi!
I have problems with js in IE. I have such script:

<script type="text/javascript">
 $(document).ready(function(){
        cl = new commentsController();
}
</script>

After that I have an onclick event:

<a href="#" class="write writereview" onClick="return cl.addCommentUnauth();">
    <?php echo $msg['write_a_review']; ?>
</a>

commentController is defined in an external file. This works fine in all browsers except IE. In IE I have error 'cl' is undefined.
I tried to connect comment-controller file

<script type="text/javascript" src="/media/js/comments/comments-controller.js">
 $(document).ready(function(){
        cl = new commentsController();
}
</script>

but then I have the same error in firefox too.
Please help me to resolve this.
Thank you!

007Julien

What is this comments-Controler.js that you used apparently with jQuery ?

DanInMA

try declaring the variable , IE can be picky about that.

<script type="text/javascript" src="/media/js/comments/comments-controller.js">
 $(document).ready(function(){
       [COLOR="Red"]var [/COLOR]cl = new commentsController();
}
</script>

Kever

Code between scripttags pointing to an external file isn't executed.

<script type="text/javascript" src="/media/js/comments/comments-controller.js"></script>

<script type="text/javascript" >
 $(document).ready(function(){
        cl = new commentsController();
}
</script>

DanInMA

wow, I must be tired to have missed that one.

Kever;1172843 wrote:
Code between scripttags pointing to an external file isn't executed.
<script type="text/javascript" src="/media/js/comments/comments-controller.js"></script>

<script type="text/javascript" >
 $(document).ready(function(){
        cl = new commentsController();
}
</script>

kromol

I've already tried all these methods but nothing helps.
If I write such script:

<script type="text/javascript" src="/media/js/comments/comments-controller.js"></script>  

<script type="text/javascript" >  

    $(document).ready(function(){         

        cl = new commentsController(); 
    } 
</script>

IE says that 'commentsController' is undefined
comment-controller.js is:

commentsController = function(){
    this.object_name = '';
    this.object_id = 0;
    this.current_order_type = '';
    this.current_count = 0;
    this.init = function(object_name, object_id, order_type, current_count) {
        this.object_name = object_name;
        this.object_id = object_id;
        this.current_order_type = order_type;
        this.current_count = current_count;
        this.initSlider();
    }
    this.addCommentUnauth = function() {
        currentPage.showLoginBox(not_auth_marking_comments); 
        return false;
    };
......................................................................................
};

DanInMA

then you probably need to declare your variables properly

commentsController = function(){

should be

var commentsController = function(){

and cl = new commentsController();

should be:

var cl = new commentsController();

kromol

still in onclick event IE says that 'cl' is undefined, though it is declared properly in this file.
and also i have error in comment-controller.js when I wrote
var commentsController = function(){

    this.initSlider = function() {
         $('#customer_slider').slider({
            range:    'min',
            min:      0,
            max:      21,
            step:     1,
            slide:    function(event, sl){cl.slideValue(this, sl); return true},
            change:   function(event, sl){cl.slideValue(this, sl); return true}
        });
}

error stayed the same 'cl' is undefined but now it is also in firefox

007Julien

You have probably to declare cl as global variable and not only in the anonymous function.

<script type="text/javascript">
var cl;
$(document).ready(function(){
        cl = new commentsController();
}
</script>

CaptainSessa

Hi,

as Julien said, variables declared within functions are only visible within these funcs.

If you want them to be visible outside, just declare them on the top of your JS code and not within any function.

eg:

var a;

function myFunc()
{
   var b = "Hello";
         a = "Hello";
}

alert(a); //Alerts hello
alert(b); //undefined -> error

Jeff_Mott

Declaring variables with var is definitely good practice, but it doesn't seem to be the cause of the issue here.

kromol, you started to trace the real source of the error: cl is undefined because commentsController is undefined. The real error is somewhere in comments-controller.js. You'll need to post that whole file if we're going to help you spot the error. Or, even better, post a link to the page so we can use dev tools to troubleshoot.

EDIT: Actually, it's probably essential that you post a link to the page. The global variables make it impossible to look at just one script file in isolation.

kromol

Declaring cl as global variable solved the problem.
Thank You!