Define a simplest class

This site is best viewed in a modern browser with JavaScript enabled.

html20009876

function MyClass()
{
	[B][COLOR="Red"]this[/COLOR][/B].setPanStyleByName = function(idName,t,r,b,l,i100)
	{
		var o=window.document.getElementById(idName);
		[B][COLOR="Red"]this[/COLOR][/B].setPanStyleByNode(o,t,r,b,l,i100);
	}

[B][COLOR="Red"]this[/COLOR][/B].setPanStyleByNode = function(o,t,r,b,l,i100)
{
        ...
}
}

The class includes 2 functions, first function calls second function.
Anyway, the class has error and doesn't work.

What is wrong?

Thanks.

rtrethewey

You define the object's functions in the wrong order. When you define setPanStyleByName(), it refers to setPanStyleByNode(), which doesn't exist yet.

Jeff_Mott

The code looks fine to me. The problem is probably somewhere in all the code you haven't shown us.

Kor

You judge JavaScript as it would be a class based language, which is not.

You have there is a constructor, not a class. That makes the inner functions to be the methods of the object, not the methods of the constructor.

That makes the token this to have different meanings, according to the scope. And there is a difference between the function declaration and the function expression.

Try this:

function MyClass()
{
	this.setPanStyleByName = function(idName,t,r,b,l,i100)
	{
		var o=window.document.getElementById(idName);
		[COLOR="Blue"]setPanStyleByNode(o,t,r,b,l,i100);[/COLOR]
	}

this.setPanStyleByNode = function(o,t,r,b,l,i100)
{
        ...
}
[COLOR="Blue"]var setPanStyleByNode=this.setPanStyleByNode;[/COLOR]
}

Jeff_Mott

Kor;1206814 wrote:
Try this:
		[COLOR="Blue"]setPanStyleByNode(o,t,r,b,l,i100);[/COLOR]

I think that's actually a bad change. Now when setPanStyleByNode executes, its "this" value will be the global/window object, rather than the MyClass instance* object.

Using the term "instance" loosely.

Kor

Jeff Mott;1206819 wrote:
I think that's actually a bad change. Now when setPanStyleByNode executes, its "this" value will be the global/window object, rather than the MyClass instance* object.

Using the term "instance" loosely.

No, it is not global as long as it is defined inside the constructor. have you noticed?

function MyClass()
{
[B][COLOR="Blue"]var[/COLOR][/B] setPanStyleByNode=this.setPanStyleByNode;
}

Probably I should have avoided the confusion if I would write like:

function MyClass()
{
	this.setPanStyleByName = function(idName,t,r,b,l,i100)
	{
		var o=window.document.getElementById(idName);
		[COLOR="Blue"]foo[/COLOR](o,t,r,b,l,i100);
	}

	this.setPanStyleByNode = function(o,t,r,b,l,i100)
	{
            ...
	}
[COLOR="Blue"]var foo=this.setPanStyleByNode;[/COLOR]
}

Jeff_Mott

A simple test:

function Test()
{
    this.method1 = function()
    {
        foo();
    }

this.method2 = function()
{
    console.log(this); // DOMWindow
}

var foo = this.method2;
}

var t = new Test();
t.method1();

The way you changed the code will cause method2 to be invoked incorrectly.

Kor

A simple test:

function myClass(){
	this.method2=function(arg){
	arg++;
	method1(arg);
	}
	this.method1=function(arg){
	alert(arg)
	}
	var method1=this.method1;
}
var myObject=new myClass();
myObject.method1(1);
myObject.method2(1);

Jeff_Mott

Neither of those methods use the "this" value. All you did was avoid revealing the mistake.

Kor

Jeff Mott;1206825 wrote:
Neither of those methods use the "this" value. All you did was avoid revealing the mistake.

Nonsense. Why should they use the token this by all means? The OP wants to call a method of an object from within another method of the same object. There are more ways to do that. All I did was to provide what I consider the simplest one. What bothers you?

Jeff_Mott

Kor;1206829 wrote:
Nonsense. Why should they use the token this by all means?

Because that's how OOP works. The "this" object will be one of many possible instances. Once you call methods without it, then those methods can no longer access the instance that is being operated on.

Kor;1206829 wrote:
The OP wants to call a method of an object from within another method of the same object. There are more ways to do that. All I did was to provide what I consider the simplest one. What bothers you?

There's lots of code the OP hasn't shown us. It's very likely that his setPanStyleByNode method uses "this" in some way. But if he implements your suggestion, then "this" will be the wrong value.

In short, your suggestion did not solve the original problem, and will likely create new problems.

svidgen

This thread has taken a bad turn. Starting from the top, this response is perfect:

Jeff Mott;1206813 wrote:
The code looks fine to me. The problem is probably somewhere in all the code you haven't shown us.

There's nothing wrong with the originally posted code, except for the placeholders and lack of context.

Some error message text would be helpful too ...

html20009876

Thanks for all of above,

I figure it out: problem is at other places, not inside the class.

:p:p:p:p:p:p:p:p:p:p