Javascript code help

This site is best viewed in a modern browser with JavaScript enabled.

moneysharma

Code below is not working...nothing happens on clicking submit...javascript is enabled in browser..help please.


<html>

<head>

<script type="text/javascript">

function match()
{
var aa=document.getElementById("username").Value;

var bb=document.getElementById("password").Value;

if(aa==null || bb==null)
{
alert("Enter Again");
}


else if((aa=="admin") && (bb=="12345"))
{
Alert("Hello Sir");
}
else if((aa=="guest") && (bb=="67890"))
{
Alert("Hello Guest");
}
else
{
Alert("Enter Valid Info");
}



}
</script>



</head>

<body>


Username:<input type="text" id="username"/><br/>

Password:<input type="text" id="password"/><br/>

<input type="submit" onClick="match()"/>




</body>


</html>

chrisranjana

Alert should be alert

jc_rotor

Also, you should avoid placing your curlybraces on the line after your parenthesis(). Some say its a matter of preference but it can matter in certain circumstances. A bad habit to start early on. Proper syntax is :

function myFunction() {
  var myVariable = "Welcome";
  alert(myVariable);
}

I would also avoid the use of non-descriptive variables such as "aa" or "bb". Use something that describes what the variable holds without being too lengthy. There is nothing wrong with username or password as variable names. Again, being picky but its a bad habit to start early on.