Shorten this code?

This site is best viewed in a modern browser with JavaScript enabled.

WayneISWayne

Is there a way to short and make this function faster, smaller and better?

function rand() {
var r = Math.floor(Math.random()*array.length);
document.getElementById('obj').innerHTML = array[r];
}

JMRKER

WayneISWayne;1209518 wrote:
Is there a way to short and make this function faster, smaller and better?

function rand() {
var r = Math.floor(Math.random()*array.length);
document.getElementById('obj').innerHTML = array[r];
}

Don't know why you would want to do that but...

function rand() {
  document.getElementById('obj').innerHTML = array[Math.floor(Math.random()*array.length)];
}

Unless you are repeating it like a million times, I don't think the space or time difference will be significant!

WayneISWayne

Thank you so much! I'm trying to make a really small JavaScript for less load time etc... and better on benchmarks too.

007Julien

A shorter method ?

function rand() {
  document.getElementById('obj').innerHTML = array[[COLOR="Red"]~~[/COLOR](Math.random()*array.length)];
}

WayneISWayne

007Julien;1209522 wrote:
A shorter method ?
function rand() {
  document.getElementById('obj').innerHTML = array[[COLOR="Red"]~~[/COLOR](Math.random()*array.length)];
}

Dose the tilde work on all browsers?

Declan1991

Well, if you are repeating that a lot, it's not good to be calling document.getElementById so much. Storing a reference would probably be better. Short code doesn't necessarily mean it's faster.

WayneISWayne

Declan1991;1209532 wrote:
Well, if you are repeating that a lot, it's not good to be calling document.getElementById so much. Storing a reference would probably be better. Short code doesn't necessarily mean it's faster.

I know. If I do that, there would be a lot of function calls. I wish there was a better way of doing the getElementById.

007Julien

As an example, you can see this page which play chess (no castling and en passant capture) with a 1023 bytes javascript !

Logic_Ali

WayneISWayne;1209558 wrote:
I know. If I do that, there would be a lot of function calls. I wish there was a better way of doing the getElementById.

var rand = ( function () 
{   

  var elem = document.getElementById( 'obj' );

  return function()
  {
    elem.innerHTML = array[ Math.floor( Math.random() * array.length ) ]; 
  }  

} )();