Code adding 2 instead of 1

This site is best viewed in a modern browser with JavaScript enabled.

NoEffinWay

I wanted to make an image counter (Like for craigs list or something) but for some reason, the count always goes up two.

<?php
error_reporting(E_ALL);
if(!isset($_GET['id'])){
    $hits = "script-x.net";
    $font = 'fonts/astronau.ttf';
}else{
    $host = "@@@@@@@";
    $user = "@@@@@@@";
    $pass = "@@@@@@@";
    $database = "@@@@@@@";
    $con = mysql_connect($host,$user,$pass);
    if(!$con){
        die("FATAL ERROR:".mysql_error());
    }else{
        mysql_select_db($database,$con);
    }
    $id = mysql_real_escape_string(str_replace('.png','',$_GET['id']));
    $id = str_replace('.jpg','',$id);
    $get = mysql_query("SELECT * FROM table WHERE id = '".$id."'");
    while($row = mysql_fetch_array($get)){
        $hits = $row['hits'];
        $font = 'fonts/'.$row['font'];
    }
    $hits++;
    //$hits = $id;
    mysql_query("UPDATE table SET hits = '".$hits."' WHERE id = '".$id."'");
}
$img = imagecreate(200, 30);

$background = imagecolorallocate( $img,255, 255, 255 );

$text_colour = imagecolorallocate( $img, 0, 0, 0 );

imagesetthickness ( $img, 3 );

imagettftext($img, 20, 0, 5, 24, $text_colour, $font, $hits);

//header( 'Content-type: image/jpeg' );
header('Content-type: image/png');

//imagejpeg( $img );
imagepng($img);


imagecolordeallocate( $text_color );
imagecolordeallocate( $background );
imagedestroy( $img );
?>

It can be access at http://script-x.net/craigslist/1.jpg (with mod rewrite) or at http://script-x.net/craigslist/counter.php?id=1

It happens either way. Anybody see why?

simplypixie

I haven't really looked at why this is happening, but just change your query (much easier) to

 $get = mysql_query("SELECT font FROM table WHERE id = '".$id."'"); 
    while($row = mysql_fetch_array($get)){ 
        $font = 'fonts/'.$row['font']; 
    } 
    mysql_query("UPDATE table SET hits = hits+1 WHERE id = '".$id."'");

webdeveloper932

Why still use the mysql set of functions? you really should be using either mysqli or PDO even php.net suggest this as to they have plans on taking the mysql set of functions out completely in the near future or rather making them depreciated

NoEffinWay

I know this. But that doesn't answer my question.

webdeveloper932

Yea im not answering ur question im giving u advice either take that or leave it

Derokorian

When I click the link, it opens in my browser (as expected). If I then click refresh over and over, it goes up only 1 each time I click refresh. As far as I can tell that means its functioning properly.

NoEffinWay

Hmm, for me, it goes up by 2 each time.

webdeveloper932

works fine for me to

NoEffinWay

I tried it in chrome and it works....it seems firefox is requesting it twice.

Derokorian

Oh firefox, why do you do some strange things that no one ever expects. I just thought of 3 ways to prevent this, and loopholes in each theory. I wonder if its just going to the file directly. Can you try putting the url in the src of an img tag, and see if it still requests twice? If not then there's no reason to worry, otherwise the counter will just be inaccurate.

webdeveloper932

Im using firefox and it works fine

arieph

yea I've seen,
thats works, and fine,
but perfection need more to do...

simplypixie

Have you actually implemented the code I posted (updating the count in the query rather than before)??