Validate Image with exif_imagetype but still able to upload non image files

This site is best viewed in a modern browser with JavaScript enabled.

Validate Image with exif_imagetype but still able to upload non image files

phpnewbie08

I am not sure if my exif_imagetype is coded wrong. It send the email just fine with photos attached. But when I try to attach non image files I am not getting the error message and it still send the email to me. Please help.

ob_start();
require("class.phpmailer.php");

$photo = $_FILES['photo'];

isset($_POST['submit']);
$active_keys = array();
foreach($_FILES[$photo]['name'] as $key => $filename){
if(!empty($filename)){
    $active_keys[] = $key;
}    }

foreach($active_keys as $key){    

switch(exif_imagetype($_FILES[$photo]['tmp_name'][$key])) {
case IMAGETYPE_JPEG:
case IMAGETYPE_PNG:
    break;
    default:
 echo "{";
 echo        "$errors: 'This is no photo..'\n";
 echo "}";
  exit(0);
    } }
$message = "some message";
$mail = new PHPMailer();
$mail->From     = ('sample@youdomain.net');
$mail->AddAddress=('sample@youdomain.net');
$mail->Subject  = "Submitted Photos";
$mail->Body     = $message;
$mail->WordWrap = 50;

foreach($_FILES['photo']['tmp_name'] as $photo) 
if(!empty($photo)) {
     $mail->AddAttachment($photo);
}

$mail->Send();


header("Location: thankyou.php");
   exit();     

   }}

NogDog

It might be interesting to see if your $active_keys array actually has some data before you loop through it, e.g.:

}

error_log("active keys array: ".print_r($active_keys, 1));

foreach($active_keys as $key){

phpnewbie08

I have pasted your above code in the script and there is nothing printed. It still just go through and send the email.

NogDog

error_log() will write it to the applicable PHP error log. If you want to just output it to the browser for debugging purposes (i.e. you don't want it in the live code):

echo "<pre>Active Keys:".PHP_EOL.var_export($active_keys, true)."</pre>";

phpnewbie08

I put the code as follow but still didn't get any message. However, I no longer receive the email either. please help.

	isset($_POST['submit']);
	$active_keys = array();
	foreach($_FILES[$photo]['name'] as $key => $filename)
	{
	if(!empty($filename))
	{
    $active_keys[] = $key;
	}    }

echo "<pre>Active Keys:".PHP_EOL.var_export($active_keys, true)."</pre>";  

foreach($active_keys as $key){  

		switch(exif_imagetype($_FILES[$photo]['tmp_name'][$key])) {
		case IMAGETYPE_JPEG:
		case IMAGETYPE_PNG:
    	break;
		default:
   	 echo "{";
   	 echo        "$errors: 'This is no photo..'\n";
   	 echo "}";
  	  exit(0);
		} }