Unable to call function from after adding js file

This site is best viewed in a modern browser with JavaScript enabled.

Unable to call function from after adding js file

Ashish_Sood

Hi,

I am new to this technology, I had created rules.js file in which i mentioned validate function which is used for required field validator for textarea. but after adding the js file in my html page i unable to call that function please let me know what i am doing wrong.

rules.js file

<script>

   function validate()
   {
      var req=document.forms["registration"]["comments"].value;

  if (req==null || req=="")
  {
     alert("");
     return false;
  }
   }
</script>

HTML Page

<script type="text/javascript" src="rules.js"></script>

Form Tag

<form id="registration" name="registration" method="POST" action="" onsubmit="return validate();">

If i add this function on the same HTML page, the after i don't face any problem to calling it, but i want to call it from source file.

Logic_Ali

.js files contain only script statements. Use the error console.

Ashish_Sood

@logic ali

It will be more good for me and others if you explain with example , its hard for me to understand.

Logic_Ali

Ashish Sood;1285361 wrote:
@logic ali

It will be more good for me and others if you explain with example , its hard for me to understand.

Delete the <script> tags in the .js file.

Shanu_chaudhary

Your rules.js file should contain only the function; You should not include the code in .js files with <script>... </script> tags when you call in .js files

   function validate()
   {
      var req=document.forms["registration"]["comments"].value;

  if (req==null || req=="")
  {
     alert("");
     return false;
  }
   }

Hope this is very clear

Ashish_Sood

Is i am doing right actually i am trying to validate 3 text fields, but its not working.

the validate function is working fine with one text field. Code is below

function validate() {
var inc=document.forms["form1"]["incoming"].value  //text field
    var out=document.forms["form1"]["outgoing"].value //text field
    var com=document.forms["form1"]["comments"].value //text area

	if (inc==null || inc=="" || out==null || out=="" || com==null || com="" ) {

	alert("All fields are mandatory");
	return false;
}
[/QUOTE]
Please tell me where is am wrong.

Thanks

Padonak

Ashish Sood;1286225 wrote:
...
Please tell me where is am wrong....

you are wrong at this point:

com[B][COLOR="#FF0000"][SIZE=3]=[/SIZE][/COLOR][/B]"" ) {

Ashish_Sood

Thanks alot Padonak

It was a typo mistake, Now its working

Thanks

Logic_Ali

Minimal validation consists of testing for non-whitespace characters. Testing for a non-empty string is inadequate:

function validate() 
{
   var inc=document.forms["form1"]["incoming"].value  //text field
   var out=document.forms["form1"]["outgoing"].value //text field
   var com=document.forms["form1"]["comments"].value //text area

   var rxp = /\S/, ok = true;

   if ( !rxp.test( inc ) || !rxp.test( out ) || !rxp.test( com ) ) 
   {
     alert("All fields are mandatory");
     ok = false;
   }

   return ok; /* A function should return a value either always or never, but not sometimes. */
}