program will not display

This site is best viewed in a modern browser with JavaScript enabled.

plat

I was hoping that someone could please look at this and tell me what I am doing wrong. It will not display any results. I have looked it over but I cannot see why it will not display. Thank You.

JavaScript>

function check_Grade()
{
	 var percent = document.gradeForm.percent.value;
	 //var percent = parseFloat(percent);
	 var absences = document.gradeForm.absences.value;
	 //var absences = parseInt(absences);

	if (absences >= 5)
		document.gradeForm.Comments.value = "You have an F because of excessive absentees";
	else if (percent >= 90 || <= 100 && absences <= 2)
	{
		document.gradeForm.Comments.value = "You have gained 3% to your percent for having few absences."/n"
		Your Grade: A, Your Percent: + percent * 0.3";
	}
	else if (percent >= 90 || <= 100)
		document.gradeForm.Comments.value = "Your Grade: A, Your Precent: + percent";
	else if (Percent <= 89.9 || >= 80)
	{
		document.gradeForm.Comments.value = "Your Grade: B, Your Precent: + percent";
	}
	else if else if (Percent <= 89.9 || >= 80 && absences <= 2)
	{
		document.gradeForm.Comments.value = "You have gained 3% to your percent for having few absences."/n"
		Your Grade: B, Your Percent: + percent * 0.3";
	}
	else if (percent <= 79.9 || >= 70)
	{
		document.gradeForm.Comments.value = "Your Grade: C, Your Precent: + percent";
	}
	else if (percent <= 79.9 || >= 70 && absences <= 2)
	{
		document.gradeForm.Comments.value = "You have gained 3% to your percent for having few absences."/n"
		Your Grade: C, Your Percent: + percent * 0.3";
	{
	else if (percent <= 69.9 || >= 60)
	{
		document.gradeForm.Comments.value = "Your Grade: D, Your Precent: + percent";
	}
	else if (percent <= 69.9 || >= 60 && absences <= 2)
	{
		document.gradeForm.Comments.value = "You have gained 3% to your percent for having few absences."/n"
		Your Grade: D, Your Percent: + percent * 0.3";
	}
	else 
	{
		document.gradeForm.Comments.value = "I am sorry you have fail this semeseter."/n"
		Your Grade: F, Your Percent: + percent";
	}
}

HTML

<!doctype html>
<html>
	<head>
		<title>Grade Reporter</title>
		<meta charset="utf-8" />
		<script type="text/javascript" src="sureGrade.js"></script>
	</head>
	<body>
		<form name="gradeForm" action="#">
			<label for="absences">How many absences do you have?: </label><br />
			<input type="text" name="absences" />
			<br />
			<label for="percent">What is your grade percent? </label><br />
			<input type="text" name="percent" />
			<br />
			<textarea name = "Comments" readonly = "true" value = "Comments" rows = "5" cols = "20"></textarea>
			<input type="button" value="Check Grade" onclick="check_Grade()" />
			<br />
		</form>
	</body>
</html>

plat

I am wondering if I need to have the (percent >= 90 || <= 100) like this (percent >100) and then the next one (percent >89.9).

root

I suggest that you turn on your javascript console, this will tell you what javascript errors you have and you should be able to solve your homework problems that way

To help you on your way... you have allot of silly errors, one of which is the ."/n" you are using, that is PHP not javascript, in javascript its a straight forward \n note that its a back slash

root

FYI as a test, I used only the JavaScript console to tell me what errors were in the script, I found them and corrected them and it took less than 5 minutes to get the script functioning.

plat

\\.\;1291415 wrote:
FYI as a test, I used only the JavaScript console to tell me what errors were in the script, I found them and corrected them and it took less than 5 minutes to get the script functioning.

Yes I have that open but to be truthful I most of the time don't understand what the errors are. I will keep working on it though. Thank You

root

OK, lets look at this then.

You javascript console will tell you what the error is and depending on your browser, the line number.

Firstly what browser are you using?

Secondly, what is the first error reported in your console?

root

So we are both on the same page, use this html page in the zip file.

If you are not using google chrome, I suggest that you grab a copy as it is a pretty useful browser to have and the javascript console is better than others IMHO

The attachments of this post were removed during the platform migration in 2018

plat

Ok thanks for taking the time to talk to me. I got chrome and I have the console displayed and it tells me this
Uncaught SyntaxError: Unexpected token <= on line 16. I have also changed the "new line" to "\n".

plat

When I try to run it the console tells me that "check_grade is not defined" Can you explain to me what this means? Please,

root

Ok, one of the first problems with variables and names is that human error in typo's creep in.

With your <= on line 16, you will see that you are making a logical test against a variable, you have part of this test done correctly, whats missing from the otherside?

for example

if( someVar1 >= x || someVar2 <=1000){
    // Do something
}

The newline character as you have put does not need wrapping in quotes, you use it like this

v = "This is my text\r\n" + 
"on two lines";

Remember that \r\n is the character combo for windows based operating systems and \n is for *nix OS's like Linux / Unix systems.

So...

Check spellings of variables and function names
Check your conditional logic
Check you have used your \r\n or \n properly.

plat

\\.\;1291519 wrote:
Ok, one of the first problems with variables and names is that human error in typo's creep in.

With your <= on line 16, you will see that you are making a logical test against a variable, you have part of this test done correctly, whats missing from the otherside?

for example
if( someVar1 >= x || someVar2 <=1000){
    // Do something
}
The newline character as you have put does not need wrapping in quotes, you use it like this
v = "This is my text\r\n" + 
"on two lines";
Remember that \r\n is the character combo for windows based operating systems and \n is for *nix OS's like Linux / Unix systems.

So...

Check spellings of variables and function names

Check your conditional logic

Check you have used your \r\n or \n properly.

Can you tell me what "Uncaught ReferenceError: check_grade is not defined "? Please
I did find that percent was spelled wrong and semester but I did not see another one. I also fixed the (percent >= 90 || percent <= 100 && absences <= 2). Am I getting there?

root

Spot on, little things like that cause errors, what you need to do is correct all those errors because you have a few of them. I can tell you that you do have one error that will be reported and it will be on the wrong line number, the clue is that the error is on the line before it.

Can you try correcting all the other errors and typos then try again.

Uncaught ReferenceError: check_grade is not defined

this is not defined because the javascript interpreter wasn't able to make sense of your coding, this shows that you have an error in the function still.

Unlike HTML markup, javascript isn't robust and can be broken easily.

root

Can you tell me what line number that error gave, it does help?

plat

\\.\;1291537 wrote:
Can you tell me what line number that error gave, it does help?

It was line 68

root

Doesn't make any sense, are you using the version I uploaded?

It might be better to copy and paste exactly as your code is in your editor to see if you have made any other changes that will affect the line number error. Remember to use the CODE tags when posting.

I will be heading off to bed very soon, if you don't get a response tonight, I will tomorrow.

root

I note that the error says check_grade() and your function is check_Grade(), did you change the function name?

plat

\\.\;1291543 wrote:
Doesn't make any sense, are you using the version I uploaded?

It might be better to copy and paste exactly as your code is in your editor to see if you have made any other changes that will affect the line number error. Remember to use the CODE tags when posting.

I will be heading off to bed very soon, if you don't get a response tonight, I will tomorrow.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
<script>
function check_grade()
{
	 var percent = document.gradeForm.percent.value;
	 var percent = parseFloat(percent);
	 var absences = document.gradeForm.absences.value;
	 var absences = parseInt(absences);

	If (absences >= 5) 
	{
		document.gradeForm.comments.value = "You have an F because of excessive absentees";
	}
    If (percent >= 90 || percent <= 100 && absences <= 2)
	{
		document.gradeForm.comments.value = "You have gained 3% to your percent for having few absences. + \n"
		"Your Grade: A, Your Percent: + percent * 0.3";
	}
	If (percent >= 90 || percent <= 100)
		document.gradeForm.comments.value = "Your Grade: A, Your Percent: + percent";
	If (percent <= 89.9 || percent  >= 80)
	{
		document.gradeForm.comments.value = "Your Grade: B, Your percent: + percent";
	}
	If (percent <= 89.9 || percent >= 80 && absences <= 2)
	{
		document.gradeForm.comments.value = "You have gained 3% to your percent for having few absences. + \n"
		"Your Grade: B, Your Percent: + percent * 0.3";
	}
	If (percent <= 79.9 || percent >= 70)
	{
		document.gradeForm.comments.value = "Your Grade: C, Your Percent: + percent";
	}
	If (percent <= 79.9 || percent >= 70 && absences <= 2)
	{
		document.gradeForm.comments.value = "You have gained 3% to your percent for having few absences. + \n"
		"Your Grade: C, Your Percent: + percent * 0.3";
	{
	If (percent <= 69.9 || percent >= 60)
	{
		document.gradeForm.comments.value = "Your Grade: D, Your Percent: + percent";
	}
	If (percent <= 69.9 || percent >= 60 && absences <= 2)
	{
		document.gradeForm.comments.value = "You have gained 3% to your percent for having few absences. + \n"
		"Your Grade: D, Your Percent: + percent * 0.3";
	}
	Else 
	{
		document.gradeForm.comments.value = "I am sorry you have fail this semester. + \n"
		"Your Grade: F, Your Percent: + percent";
	}
	}
</script>
</head>

<body>		
<form name="gradeForm" action="#">
   <label for="absences">How many absences do you have?: </label><br />
   <input type="text" name="absences" /><br />
   <label for="percent">What is your grade percent? </label><br />
   <input type="text" name="percent" /><br />
   <input type="button" value="Check Grade" id="checkGradeButton"  onclick="check_grade()" />
   <label for="comments">COMMENTS: </label>
   <textarea id="comments"></textarea>
</form>
</body>
</html>

plat

yes i was just stabbing at things

plat

it now gives me these

Uncaught SyntaxError: Unexpected end of input grades.html:1
Uncaught ReferenceError: check_grade is not defined grades.html:67

root

Looking at the code

This is wrong...

ces. + \n"

it should be

ces.\n" +

because in javascript you are adding a further element to the end of an existing string which in this case is a string.

If and Else is fine if you were writing in VBscript but we aint!

You need to put back all the

if( ...){
// do something

}else if(...

because javascript uses lower case if , else if conditionals.

so putting all the if else's properly, on my javascript console I get

Uncaught SyntaxError: Unexpected token else grades.html:43 on line 43 BUT !!! that is not where the error is, it is actually the line above it.

So without changing the line numbers, just the elements that need putting back in to play, you should get the same error. Can you spot it?

You still have code problems but we will discuss those in a bit...