doument.getElementById Breaking code

This site is best viewed in a modern browser with JavaScript enabled.

themightymanuel

I have the following code

if( depth > 140 )
	{
		document.getElementById("divetimes").innerHTML = ('<p>There is no safe no decompression time for this depth.</p>');
	}
else
	{
		document.getElementById("divetimes").innerHTML = ('<p>At that depth your no decompression limit is <em class = myclass2>' + nodetime + '</em> minutes. You need to make a saftey if your down at least <em class = myclass3>' + sstime + '</em> minutes.</p>' );	
	};

Whenever either of them happens it breaks the code and does nothing and causes all code that follows to not get executed. I tried commenting them out and as long as the one that will be executed is commented out everything after it works. Things that are placed before this section still work fine.

themightymanuel

I actually found the problem. I had called the script before creating the element.

rtrethewey

Try:

if( depth > 140 )
	{
		document.getElementById("divetimes").innerHTML = '<p>There is no safe no decompression time for this depth.</p>';
	}
else
	{
		document.getElementById("divetimes").innerHTML = '<p>At that depth your no decompression limit is <em class = myclass2>' + nodetime + '</em> minutes. You need to make a saftey if your down at least <em class = myclass3>' + sstime + '</em> minutes.</p>';	
	};

The 'innerHTML' property needs to be a string. The browser may not like the parenthesis you were using. You also need to make sure that there is actually an element in the document with the 'id' attribute set to "divetimes".

In either case, you should have a debugging tool available to point out the error. MSIE comes with one in the F12 Developer Tools. Chrome and Firefox have add-ons available. Check them out and you'll find your error.

themightymanuel

I actually found the problem. I had called the script before creating the element.