Php problem

#native_company# #native_desc#

#native_cta#

This site is best viewed in a modern browser with JavaScript enabled.

ruft3r

Gooed evening;

Im new with php and i got some application that i create as learn proces.

But nog i have an problem. and i can't solve :s

Im trying to edit one row on mij sql data. But if i do the data of all rows would be edited. And that not my intention i want to update that one specific row. Plz help me!

http://st-joris-turnhout.be/man/log-ins-test.php a working example of the bug.

code:

my database:

CREATE TABLE IF NOT EXISTS `logins` (
  `ID` int(11) NOT NULL AUTO_INCREMENT,
  `Website_applicatie` varchar(150) NOT NULL,
  `Login` varchar(150) NOT NULL,
  `Pass` varchar(150) NOT NULL,
  `Notitie` varchar(255) NOT NULL,
  PRIMARY KEY (`ID`)
) ENGINE=MyISAM  DEFAULT CHARSET=latin1 AUTO_INCREMENT=35 ;

function:

$id =$_REQUEST['ID'];

$result = mysql_query("SELECT * FROM logins WHERE ID  = '$id'");
$row = mysql_fetch_array($result);
if (!$result) 
		{
		die("Error: Data is niet gevonden");
		}

			// Laad de bestaande data in de form
			$web_app=$row['Website_applicatie'] ;
			$login=$row['Login'] ;					
			$pass=$row['Pass'] ;
			$notitie=$row['Notitie'] ;
			$weblink=$row['Hyperlink'];

if(isset($_POST['save']))
{	
	// Wijzigd de data
	$web_app_save = $_POST['webapp'];
	$login_save = $_POST['login'];
	$pass_save = $_POST['pass'];
	$notitie_save = $_POST['notitie'];
	$hyperlink_save = $_POST['hyperlink'];

mysql_query("UPDATE logins SET Website_applicatie ='$web_app_save', Login ='$login_save', Pass ='$pass_save', Notitie ='$notitie_save', Hyperlink ='$hyperlink_save'")
			or die(mysql_error()); 
echo "Uw wijziging is doorgevoerd!";

header("Location: ../log-ins-test.php");			
}
mysql_close();
?>

trigger:

<a class="label label-default" href="includes/edit.php?ID=129"><span class="glyphicon glyphicon-pencil"></span> Edit</a>

I hiope u can help me guys

NogDog

Looks like you need a WHERE clause in your UPDATE query to tell it which row to update, presumably on the ID field, which it appears will be available in $_GET['ID'].

ruft3r

NogDog;1296887 wrote:
Looks like you need a WHERE clause in your UPDATE query to tell it which row to update, presumably on the ID field, which it appears will be available in $_GET['ID'].

can u give me some more info plz i don't understand it well. or can u give me a patch

NogDog

if(empty($_GET['id']) or !ctype_digit($_GET['ID'])) {
  die("ID not received or it is not an integer.");
}
$id = (int) $_GET['ID'];
$sql = "
  UPDATE logins SET 
    Website_applicatie ='$web_app_save',
    Login ='$login_save',
    Pass ='$pass_save',
    Notitie ='$notitie_save',
    Hyperlink ='$hyperlink_save'
  WHERE ID = $id
";
mysql_query($sql);

ruft3r

NogDog;1296897 wrote:
if(empty($_GET['id']) or !ctype_digit($_GET['ID'])) {
  die("ID not received or it is not an integer.");
}
$id = (int) $_GET['ID'];
$sql = "
  UPDATE logins SET 
    Website_applicatie ='$web_app_save',
    Login ='$login_save',
    Pass ='$pass_save',
    Notitie ='$notitie_save',
    Hyperlink ='$hyperlink_save'
  WHERE ID = $id
";
mysql_query($sql);

and how i implement this code?

NogDog

It would replace this line:

    mysql_query("UPDATE logins SET Website_applicatie ='$web_app_save', Login ='$login_save', Pass ='$pass_save', Notitie ='$notitie_save', Hyperlink ='$hyperlink_save'")

StellaMaris

Thanks For your explanation, but i need some more explanation. Because now only i am learning PHP.

ruft3r

NogDog;1297005 wrote:
It would replace this line:
    mysql_query("UPDATE logins SET Website_applicatie ='$web_app_save', Login ='$login_save', Pass ='$pass_save', Notitie ='$notitie_save', Hyperlink ='$hyperlink_save'")

but then i recive this error"ID not received or it is not an integer."