PHP form and MySQL

This site is best viewed in a modern browser with JavaScript enabled.

gsmkam

Am getting a error when am trying connect inputs from my contact form to my database. Please have a look at following code
HTML

<div id='frmFormMailContainer'>
<h2>Contact Us</h2><form name="Contacts" method="post" action="Insert.php">
<div class="formItem" id="fnamef">
<label for="FirstName" class="testLabel">First name</label>
  <input type="text" name="FirstName" id="FirstName">
</div>
<div id="lnamef">
<label for="LastName" class="textLabel">Last name</label>
<input type="text" name="LastName" id="LastName">
</div>
<div id="emailf">
<label for="Email" class="textLabel">Email </label>
<input type="text" name="Email" id="Email">
</div>
<div id="mobilef">
<label for="Mobile" class="textLabel">Mobile</label>
<input type="tel" name="Mobile" id="Mobile">

<div id="Message">
<label for="Message" class="textLabel">Message</label>
<input type="text" name="Message" id="Message">
</div>
<br>
<div id="submitf">
<input type="submit" name="submit" id="submit" value="Submit">
</form> </div>
</div>

and PHP

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>Untitled Document</title>
</head>

<body>
</body>
</html>
<?php
    $username="root";
    $password="";
    $database="test1";

$FirstName = $_POST["FirstName"];
$LastName = $_POST["LastName"];
$Email = $_POST["Email"];
$Mobile = $_POST["Mobile"];
$Message = $_POST["Message"];

	echo $FirstName;
	echo $LastName;
	echo $Email;
	echo $Mobile;
	echo $Message;

  $conn=mysql_connect("localhost", "root", "")
        or die ("NO connection");

$db=mysql_select_db("test1",$conn)
or die ("Brak polaczenia");

$sql = "INSERT INTO 'test1'.'contacts' ('FirstName', 'LastName', 'Email', 'Mobile', 'Message')
        VALUES ('$FirstName', '$LastName', '$Email', '$Mobile', '$Message');";

$db=mysql_query($sql,$conn)
or die ("Error");

?>

Thanks

wevie

I think you may be having a problem with your connect function call and your insert statement.

INSERT INTO contacts

Since you are creating variables for you database info, you should use them, and also specify what database you want to connect to in the call.

$conn=mysqli_connect($host,$username,$password,$database);

Then your insert statement should look like this. I also noticed an extra semicolon at the end of the values.

$sql = "INSERT INTO 'test1'.'contacts' ('FirstName', 'LastName', 'Email', 'Mobile', 'Message')
          VALUES ('$FirstName', '$LastName', '$Email', '$Mobile', '$Message')";

unasAquila

My biggest issue with your code is mysql please please please look into mysqli or PDO
ok so your code
bad code below -> you don't need to declare the database in the query

$sql = "INSERT INTO [B]'test1'.[/B]'contacts' ('FirstName', 'LastName', 'Email', 'Mobile', 'Message') 
            VALUES ('$FirstName', '$LastName', '$Email', '$Mobile', '$Message');";

good code. notice also i have used ticks and not single quotes ' . singles quotes should only be used in the VALUES [code] $sql = "INSERT INTOcontacts(FirstName,LastName,Email,Mobile,Message`)
VALUES ('$FirstName', '$LastName', '$Email', '$Mobile', '$Message');";
[/code]

hopefully this will get you started towards fixing your code.

wevie

Why the ticks? I have queries written that is working without the ticks. I am most curious as to what the propose of those are. Should I start using them?

unasAquila

the backticks help to avoid any reserved keyword collisions. but are not always necessary and in all honesty not best practice. But i find if i have issues using backticks can help.