Having trouble with my preg_replace_callback()

#native_company# #native_desc#

#native_cta#

This site is best viewed in a modern browser with JavaScript enabled.

Having trouble with my preg_replace_callback()

jeddik

Hi,

I have a function which converts text into a header format:

Its nice because I can chose deliminators and exception

This is the string version:

function titleCase_str($string){
    $delimiters = array(" ", "-", ".", "'", "O'", "Mc");
    $exceptions = array("and", "to", "of", "das", "dos", "I", "II", "III", "IV", "V", "VI");
    $string = mb_convert_case($string, MB_CASE_TITLE, "UTF-8");
    foreach ($delimiters as $dlnr => $delimiter) {
        $words = explode($delimiter, $string);
        $newwords = array();
        foreach ($words as $wordnr => $word) {
            if (in_array(mb_strtoupper($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtoupper($word, "UTF-8");
            } elseif (in_array(mb_strtolower($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtolower($word, "UTF-8");
            } elseif (!in_array($word, $exceptions)) {
                // convert to uppercase (non-utf8 only)
                $word = ucfirst($word);
            }
            array_push($newwords, $word);
        }
        $string = join($delimiter, $newwords);
   }//foreach
   return $string;
}

This works fine on a string like this:

$the_title = "this-that is. a test of the Mcdougal title";

$test_title_out = titleCase_str($the_title);

I get this output:

This-That Is. A Test of The McDougal Title

But I only want to apply this titleCase to titles within
a body of text.

So I have tried to convert the function to use an array input:

function titleCase($matches){
    $string = $matches[1];
    $delimiters = array(" ", "-", ".", "'", "O'", "Mc");
    $exceptions = array("and", "to", "of", "das", "dos", "I", "II", "III", "IV", "V", "VI");
    $string = mb_convert_case($string, MB_CASE_TITLE, "UTF-8");
    foreach ($delimiters as $dlnr => $delimiter) {
        $words = explode($delimiter, $string);
        $newwords = array();
        foreach ($words as $wordnr => $word) {
            if (in_array(mb_strtoupper($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtoupper($word, "UTF-8");
            } elseif (in_array(mb_strtolower($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtolower($word, "UTF-8");
            } elseif (!in_array($word, $exceptions)) {
                // convert to uppercase (non-utf8 only)
                $word = ucfirst($word);
            }
            array_push($newwords, $word);
        }
        $string = join($delimiter, $newwords);
   }//foreach
   return $string;
}

And now to use the function in the preg_replace_callback()

$test = "now for a test. [hd2]this is header2[/hd] test! does THIS [hd3] this is header3 [/hd]THING work? we will soon know # willl we not ? see you soon";

$test_output2 = preg_replace_callback(
                "/(\hd[1-6](.+?)\[\/hd\])/",
                "titleCase",
                $test);

But my headings don't get converted

I get this output:

now for a test. [hd2]this is header2[/hd] test! does THIS [hd3] this is header3 [/hd]THING work? we will soon know # willl we not ? see you soon

Can anyone see what I have done wrong ?

Thanks.

jeddik

Does anyone know about these preg_replace_callback() ???

Please help.

Thanks.

chrisranjana

jeddik;1303479 wrote:
Does anyone know about these preg_replace_callback() ???

Please help.

Thanks.

.

You can have this as a starting point and then refine it further

<?php

$test = "now for a test. [hd2]this is header2[/hd] test! does THIS [hd3] this is header3 [/hd]THING work? we will soon know # willl we not ? see you soon";

$test_output2 = preg_replace_callback(
                "/\[hd[1-6]\](.+?)\[\/hd\]/",
                "titleCase_str",
                $test); 

print $test_output2;


function titleCase_str($string){
$string = $string[1];
    $delimiters = array(" ", "-", ".", "'", "O'", "Mc");
    $exceptions = array("and", "to", "of", "das", "dos", "I", "II", "III", "IV", "V", "VI");
    $string = mb_convert_case($string, MB_CASE_TITLE, "UTF-8");
    foreach ($delimiters as $dlnr => $delimiter) {
        $words = explode($delimiter, $string);
        $newwords = array();
        foreach ($words as $wordnr => $word) {
            if (in_array(mb_strtoupper($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtoupper($word, "UTF-8");
            } elseif (in_array(mb_strtolower($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtolower($word, "UTF-8");
            } elseif (!in_array($word, $exceptions)) {
                // convert to uppercase (non-utf8 only)
                $word = ucfirst($word);
            }
            array_push($newwords, $word);
        }
        $string = join($delimiter, $newwords);
   }//foreach
   return $string; 
}

?>

jeddik

Not quite sure what you mean ?

You have taken the function that does work ( titleCase_str () )
and inserted this line $string = $string[1];.

And this breaks the function.

Anyway ...

I took the same line out of the other function titleCase()

But unfortunately, it did not make it work, I get the same result:
These are my functions:


function titleCase_str($string){
	$delimiters = array(" ", "-", ".", "'", "O'", "Mc");
	$exceptions = array("and", "to", "of", "das", "dos", "I", "II", "III", "IV", "V", "VI");
    $string = mb_convert_case($string, MB_CASE_TITLE, "UTF-8");
    foreach ($delimiters as $dlnr => $delimiter) {
        $words = explode($delimiter, $string);
        $newwords = array();
        foreach ($words as $wordnr => $word) {
            if (in_array(mb_strtoupper($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtoupper($word, "UTF-8");
            } elseif (in_array(mb_strtolower($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtolower($word, "UTF-8");
            } elseif (!in_array($word, $exceptions)) {
                // convert to uppercase (non-utf8 only)
                $word = ucfirst($word);
            }
            array_push($newwords, $word);
        }
        $string = join($delimiter, $newwords);
   } // end foreach
   return $string;
}	


function titleCase($matches){
	$delimiters = array(" ", "-", ".", "'", "O'", "Mc");
	$exceptions = array("and", "to", "of", "das", "dos", "I", "II", "III", "IV", "V", "VI");
    $string = mb_convert_case($string, MB_CASE_TITLE, "UTF-8");
    foreach ($delimiters as $dlnr => $delimiter) {
        $words = explode($delimiter, $string);
        $newwords = array();
        foreach ($words as $wordnr => $word) {
            if (in_array(mb_strtoupper($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtoupper($word, "UTF-8");
            } elseif (in_array(mb_strtolower($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtolower($word, "UTF-8");
            } elseif (!in_array($word, $exceptions)) {
                // convert to uppercase (non-utf8 only)
                $word = ucfirst($word);
            }
            array_push($newwords, $word);
        }
        $string = join($delimiter, $newwords);
   } // end foreach
   return $string;
}	
	// END OF FUNCTIONS

// Test Functions

$test = "now for a test. [hd2]this is header2[/hd] test! does THIS [hd3] this is header3 [/hd]THING work? we will soon know # willl we not ? see you soon";

$the_title = "this-that is. a test of the Mcdougal title";

$test_title_out = titleCase_str($the_title);

$test_output2 = preg_replace_callback(
	"/(\hd[1-6](.+?)\[\/hd\])/",
	"titleCase",
	$test);


echo "<br><br>Test_title_out<br>$test_title_out<br><br>";

echo "<br><br>Test_output 2<br>$test_output2<br><br>";

And the output:

Test_title_out
This-That Is. A Test of The McDougal Title

Test_output 2
now for a test. [hd2]this is header2[/hd] test! does THIS [hd3] this is header3 [/hd]THING work? we will soon know # willl we not ? see you soon

jeddik

It looks OK to me,

I can not see what I did wrong here ...

bionoid

My turn

<?php

function titleCase($matches)
{
    $string = is_array($matches) ? $matches[1] : $matches;
    $delimiters = array(" ", "-", ".", "'", "O'", "Mc");
    $exceptions = array("and", "to", "of", "das", "dos", "I", "II", "III", "IV", "V", "VI");
    $string = mb_convert_case($string, MB_CASE_TITLE, "UTF-8");
    foreach ($delimiters as $dlnr => $delimiter) {
        $words = explode($delimiter, $string);
        $newwords = array();
        foreach ($words as $wordnr => $word) {
            if (in_array(mb_strtoupper($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtoupper($word, "UTF-8");
            } elseif (in_array(mb_strtolower($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtolower($word, "UTF-8");
            } elseif (!in_array($word, $exceptions)) {
                // convert to uppercase (non-utf8 only)
                $word = ucfirst($word);
            }
            array_push($newwords, $word);
        }
        $string = join($delimiter, $newwords);
   }//foreach
   return $string;
}

$test = "now for a test. [hd2]this is header2[/hd] test! does THIS [hd3] this is header3 [/hd]THING work? we will soon know # willl we not ? see you soon";
$the_title = "this-that is. a test of the Mcdougal title";

$test_title_out = titleCase($the_title);
$test_output2 = preg_replace_callback('/\[hd[1-6]\]([\w\W]*?)\[\/hd\]/', 'titleCase', $test);

echo "<br><br>Test_title_out<br>$test_title_out<br><br>";
echo "<br><br>Test_output 2<br>$test_output2<br><br>";

?>

Output

Test_title_out
This-That Is. A Test of The McDougal Title

Test_output 2
now for a test. This Is Header2 test! does THIS This Is Header3 THING work? we will soon know # willl we not ? see you soon

jeddik

I just came back to write that I was correct to have the
$string = $matches[1]; line in there otherwise
the string wasn't getting defined.

Now you have put a little if() stmt to check if $string is an array or not.

OK - is that because if the Title only has ONE word it will not be an array ?
BUT $newwords is defined as an array so can $string be anything other ?

I understand the other stuff you corrected for me.

bionoid

Calling the function directly is typically done using a string, but when the [FONT=Courier New]preg_replace_callback[/FONT] calls it, it will pass an array.

So checking if an array was passed will allow both methods to be used with only one function.

jeddik

OK - I see
( That's clever !! )

BTW isn't this line redundant ??
$string = mb_convert_case($string, MB_CASE_TITLE, "UTF-8");

bionoid

I honestly didn't look into how you were case'ing the text. Do you really need to cater for characters out of the ASCII range? You know those mb_ functions are flipping slow

jeddik

Well, The text could have Turkish or German characters in it.

But actually I can test for that because the document will be classified by language anyway.

Assuming that it is English language then, what would be a may "economical" way to case it. ?

and ...

isn't this line redundant ??
$string = mb_convert_case($string, MB_CASE_TITLE, "UTF-8");

bionoid

It does seem a little pointless, this line seems to take care of it:

$word = ucfirst($word);

jeddik

Yes,
That's what I thought.

So, I now have this, which for most cases will work a lot faster ??

function titleCase($matches){
	$string = is_array($matches) ? $matches[1] : $matches;
	$delimiters = array(" ", "-", ".", "'", "O'", "Mc");
	$exceptions = array("and", "to", "of", "das", "dos", "I", "II", "III", "IV", "V", "VI");
    if($lang_cd == 'En'){
	  foreach ($delimiters as $dlnr => $delimiter) {
        $words = explode($delimiter, $string);
        $newwords = array();
        foreach ($words as $wordnr => $word) {
            if (in_array(strtoupper($word), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = strtoupper($word);
            } elseif (in_array(strtolower($word), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = strtolower($word);
            } elseif (!in_array($word, $exceptions)) {
                // convert to uppercase (non-utf8 only)
                $word = ucfirst($word);
            }
            array_push($newwords, $word);
        }
        $string = join($delimiter, $newwords);
		}  //  end foreach
		return $string;
	  }  // end if
    else {
      foreach ($delimiters as $dlnr => $delimiter) {
        $words = explode($delimiter, $string);
        $newwords = array();
        foreach ($words as $wordnr => $word) {
            if (in_array(mb_strtoupper($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtoupper($word, "UTF-8");
            } elseif (in_array(mb_strtolower($word, "UTF-8"), $exceptions)) {
                // check exceptions list for any words that should be in upper case
                $word = mb_strtolower($word, "UTF-8");
            } elseif (!in_array($word, $exceptions)) {
                // convert to uppercase (non-utf8 only)
                $word = ucfirst($word);
            }
            array_push($newwords, $word);
        }
        $string = join($delimiter, $newwords);
		}  //  end foreach
		return $string;
	  }  // end else
	}

bionoid

Looks OK.

Did you know you could set the encoding type for all the mb_ functions?

mb_internal_encoding('UTF-8');

Then you can just make calls like:

mb_strtoupper($word)

jeddik

Hmmm ... thanks.

BTW ... How do I pass an extra parameter to the callback function ??

E.G. I have:

function titleCase($matches,$lang_cd){
blah blah
}

and ...

$test_output2 = preg_replace_callback(
	'/\[hd[1-6]\](.+?)\[\/hd\]/',
	'titleCase',
	$test);

Where do I put the $lang_cd ?

Thanks.

Oh - and you may notice I still used my B[/B]
what was the advantage of B[/B] ??

bionoid

jeddik;1303605 wrote:
Oh - and you may notice I still used my B[/B]
what was the advantage of B[/B] ??

Your expression will work with single lined data, if for some reason the content between your tags spanned multiple lines then the expression would not match.

. Matches any single character except "\n". To match any character including the '\n', use a pattern such as '[\s\S]'.

I used [FONT=Courier New][\w\W][/FONT], but it's the same thing really.

I'm not sure about how to pass extra parameters to a callback at the moment, I probably would have used a global variable, but I'm not going to say more about to save face

NogDog

Note that you can add a "s" modifier after the closing regex delimiter to have the dot character include newlines.

jeddik

OK - thanks to both.

I added/changed these lines then:

global $lang_cd;

and this:

$test_output2 = preg_replace_callback(
	'/\[hd[1-6]\](.+?)\[\/hd\]/s',
	'titleCase',
	$test);

Seems to be working OK

bionoid

NogDog;1303749 wrote:
Note that you can add a "s" modifier after the closing regex delimiter to have the dot character include newlines.

Good to know.

The description I posted was from the JavaScript RegExp object, and didn't think to look if PHP had its own proprietary flags.
For anyone interested in the possible pattern modifiers: http://php.net/manual/en/reference.pcre.pattern.modifiers.php