delete items options

This site is best viewed in a modern browser with JavaScript enabled.

Alidad

hi, I have tried to send single to php to delete items from html but is seemed to me is not sending to delete it and there is no errors at all can you see code what did i missed!

in body

  <td width="12%" align="center"><input type="submit" name="yesdelete" id="deleteid" value="Submit" />

in php

<?php
if (isset($_POST['yesdelete'])) {
//////////////////////////////////////////////////////////
// remove item from system and delete its picture
// delete from database
//////////////////////////////////////////////////////////

$id_to_delete = $_GET['yesdelete'];
if ($id_to_delete = $mysqli->query("DELETE FROM product WHERE product_id='$id_to_delete' LIMIT 1"))
/////////////////////////////////////////////////////////////
// unlink the image from server
// Remove The Pic -------------------------------------------
/////////////////////////////////////////////////////////////

$pictodelete = ("../product_images/$id_to_delete.jpg");
if (file_exists($pictodelete)) {
   		    unlink($pictodelete);
}
header("location: product-copy-4.php"); 
exit();
}
?>

ginerjm

You are wiping out the value of $id_to_delete when you run your query. Silly Silly Silly

bionoid

From the html sample you gave, I don't see how this is going to work at all....

First of all your checking if the value was sent using the POST method:

if (isset($_POST['yesdelete'])) {

Then you're pulling the actual value from the passed querystring (GET)

$id_to_delete = $_GET['yesdelete'];

If for some reason this is actually correct, the value you're sending is "[FONT=Courier New]Submit[/FONT]"

<input type="submit" [COLOR="#FF0000"]name="yesdelete"[/COLOR] id="deleteid" [COLOR="#FF0000"]value="Submit"[/COLOR] />

Also, I would remove the "LIMIT 1" from the DELETE SQL statement, I don't think that's valid (I stand to be corrected)?

unasAquila

you can use LIMIT with single int values in a DELETE query, unlike a SELECT where you can use a range

unasAquila

as @bionoid's said your mixing request variables.
if your using get use $GET or if your using post $POST

<?php 
if (isset($_GET['submit'])) { 
////////////////////////////////////////////////////////// 
// remove item from system and delete its picture 
// delete from database 
////////////////////////////////////////////////////////// 

$id_to_delete = (int) $_GET['yesdelete']; //cast to int to prevent type conflict should really do high level error checking tbh
if ($id_to_delete = $mysqli->query("DELETE FROM product WHERE product_id='$id_to_delete' LIMIT 1")) 
///////////////////////////////////////////////////////////// 
// unlink the image from server 
// Remove The Pic ------------------------------------------- 
///////////////////////////////////////////////////////////// 

$pictodelete = ("../product_images/$id_to_delete.jpg"); 
if (file_exists($pictodelete)) { 
               unlink($pictodelete); 
} 
header("location: product-copy-4.php");  
exit(); 
} 
?>