Help splitting a string

This site is best viewed in a modern browser with JavaScript enabled.

macnasty

I got this code from online and it works perfectly from the commented line down. It shows each word in a div. I added the array etc above the commented part but when I run that it shows every word in a div.

I have no idea why.

    var carArray = ['Saab', 'Volvo', 'BMW', 'GMC', 'Nissan', 'Ford'];
    var cars = carArray.toString();
    cars.split(",");

//var cars = 'Saab,Volvo,BMW,GMC,Nissan,Ford'.split(",");
for (var c in cars)

{
    var newElement = document.createElement('div');
    newElement.id = cars[c]; newElement.className = "car";
    newElement.innerHTML = cars[c];
    document.body.appendChild(newElement);
}

macnasty

I can't edit so one error, when I run my version it puts every letter into a new div.

macnasty

Sorted it by creating a new variable in the middle then passing that variable to cars so it now became

var carArray = ['Saab', 'Volvo', 'BMW', 'GMC', 'Nissan', 'Ford'];
    var carsToSplit = carArray.toString();
    var cars = carsToSplit.split(",", 2);

coothead

Hi there macnasty,
[indent]
and a warm welcome to these forums.

You seem to be over-complicating it a little bit. :eek:

This would do the job...

[color=navy]
   var cars=['Saab','Volvo','BMW','GMC','Nissan','Ford'];

for(var c in cars) {
   var newElement=document.createElement('div');
       newElement.id=cars[c]; 
       newElement.className='car';
       newElement.innerHTML=cars[c];
       document.body.appendChild(newElement);
 } [/color]

[/indent]

coothead

xelawho

you shouldn't really be using a for... in loop for arrays - they are better suited to objects. Traditionally, arrays have been iterated over using the incrementing for loop, or you can use the funky newish forEach method (modern browsers only)...

<script>
var carArray = ['Saab', 'Volvo', 'BMW', 'GMC', 'Nissan', 'Ford'];

carArray.forEach(function (val) {
        var newElement = document.createElement('div');
        newElement.id = val; 
	newElement.className = "car";
        newElement.innerHTML = val;
        document.body.appendChild(newElement);
});

</script>

deathshadow

The code you have makes a DIV for each word and plugs the word into it -- what were you expecting it to do?

On top of the bizarre redundancies, use of 'in' on an array, use of innerHTML contrary to us being told not to anymore...

I'm just not understanding what you are expecting it to do OTHER than make one DIV for each word? Do you want all the words just slapped into one DIV? Are you looking for some other tags inside a DIV or something?

sawan20

I think, you cannot split it.